fix: minimum detected chalk level #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 70.17% 70.17%
=======================================
Files 2 2
Lines 57 57
Branches 12 12
=======================================
Hits 40 40
Misses 17 17
Continue to review full report at Codecov.
|
felixfbecker
changed the title
felixfbecker
force-pushed
the
patch-1
branch
from
5f3a303 to
a91543c
Compare
Shouldn't this line be `Math.max` instead of `Math.min` if we want to support a minimum level? The way it is now, `Level.Basic` never gets applied if chalk detects a `level` of `0` since `Math.min(0, 1) === 0`
felixfbecker
force-pushed
the
patch-1
branch
from
a91543c to
eb3b4e9
Compare
|
🎉 This PR is included in version 2.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't this line be
Math.maxinstead ofMath.minif we want to support a minimum level? The way it is now,Level.Basicnever gets applied if chalk detects alevelof0sinceMath.min(0, 1) === 0