Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images don't show in Inkscape #113

Closed
ulpsbswivkbqcqebah opened this issue Feb 19, 2021 · 3 comments · Fixed by #116
Closed

Images don't show in Inkscape #113

ulpsbswivkbqcqebah opened this issue Feb 19, 2021 · 3 comments · Fixed by #116
Labels

Comments

@ulpsbswivkbqcqebah
Copy link

ulpsbswivkbqcqebah commented Feb 19, 2021

Bitmap pictures of SVG output are not visible in free vector editor named Inkscape. The reason is probably because image href attribute should be xlink:href. I tried changing following lines localy (c:\Users[username]\AppData\Roaming\Mozilla\Firefox\Profiles[profilename].default\extensions\svg-screenshots@felixfbecker.xpi\src) in (content|background).js(|.map) which solved the issue for me:

        // Inline binary images as base64 data: URL
        const dataUrl = await blobToDataURL(blob);
        element.dataset.src = element.href.baseVal;
        element.setAttribute('xlink:href', dataUrl.href);

Please include Inkscape to your testing software.

@felixfbecker
Copy link
Owner

xlink:href is deprecated as of SVG2.0 in favor of just href, so it's Inkscape who's wrong here, but I don't see an issue with using xlink:href.

https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/xlink:href

@felixfbecker felixfbecker transferred this issue from felixfbecker/svg-screenshots Apr 11, 2021
@felixfbecker felixfbecker changed the title pictures in Inkscape Images don't show in Inkscape Apr 11, 2021
felixfbecker added a commit that referenced this issue Apr 11, 2021
xlink:href is removed from SVG2.0, but non-namespaced href is not supported by Inkscape.

Fixes #113
felixfbecker added a commit that referenced this issue Apr 11, 2021
xlink:href is removed from SVG2.0, but non-namespaced href is not supported by Inkscape.

Fixes #113
@github-actions
Copy link

🎉 This issue has been resolved in version 0.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eckynde
Copy link

eckynde commented Aug 2, 2022

This issue on the Inkscape issue tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants