Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only mutate IDs in the output SVG, not the input #122

Merged
merged 1 commit into from
Apr 17, 2021
+5 −5
Merged

fix: only mutate IDs in the output SVG, not the input #122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/svg.ts
View file
Original file line number Diff line number Diff line change
@@ -95,11 +95,6 @@ export function handleSvgElement(element: SVGElement, context: SvgTraversalConte
)
break
}

// Make all IDs unique
for (const descendant of element.querySelectorAll('[id]')) {
descendant.id = context.idPrefix + descendant.id
}
} else {
// Clone element
if (isSVGAnchorElement(element) && !context.options.keepLinks) {
@@ -155,6 +150,11 @@ export function handleSvgElement(element: SVGElement, context: SvgTraversalConte
}
}

// Make sure all IDs are unique
if (elementToAppend.id) {
elementToAppend.id = context.idPrefix + elementToAppend.id
}

context.currentSvgParent.append(elementToAppend)
for (const child of element.childNodes) {
handleSvgNode(child, { ...context, currentSvgParent: elementToAppend })