Enable LS to operate without accessing the file system #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.45% (diff: 95.02%)@@ master #136 diff @@
==========================================
Files 34 35 +1
Lines 770 809 +39
Methods 104 110 +6
Messages 0 0
Branches 0 0
==========================================
+ Hits 704 748 +44
+ Misses 66 61 -5
Partials 0 0
|
1 task
* workspace/glob becomes workspace/files * return type of textDocument/files is now TextDocumentItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR decouples the LS from direct file system access by implementing the proposals for
workspace/globworkspace/filesandtextDocument/contentunderworkspace/xglobworkspace/xfilesandtextDocument/xcontent. The requests are only used when the client expressed support for them throughClientCapabilities, otherwise direct FS access is used.This turns document content retrieval and recursive file search into async operations.
In turn, all server handlers can now operate async by returning a promise.