Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing build by setting stubs ver. to older ver. #797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing build by setting stubs ver. to older ver. #797

wants to merge 1 commit into from

Conversation

CodyWilson
Copy link

phpstorm-stubs dev-master already had PHP8 features which are breaking
the parser per #795.
The simple solution for this is to force an older version of the stubs.

@CodyWilson
Fixing build by setting stubs ver. to older ver.
cb66104 
phpstorm-stubs dev-master already had PHP8 features which are breaking
the parser per felixfbecker#795.
The simple solution for this is to force an older version of the stubs.
@CodyWilson
Copy link
Author

As a note, the appveyor build failing appears to be due to updates to microsoft/tolerant-php-parser.
Which also isn't really controlled well for versions, then again they're just sticking all changes in 0.0 and not iterating for anything that could be considered a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CodyWilson