Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default time to 30s, to align with the pprof/profile default timeout #3

Closed
howardjohn opened this issue Jul 10, 2020 · 2 comments
Closed

Default time to 30s, to align with the pprof/profile default timeout #3

howardjohn opened this issue Jul 10, 2020 · 2 comments

Comments

@howardjohn
Copy link

Currently if you call the standard pprof endpoint without ?timeout set, it will default to 30. With fgprof, this just fails. It would be nice to retain this defaulting behavior.
felixge added a commit that referenced this issue Jul 11, 2020
@felixge
Default to 30s duration like net/http/pprof
7b3aa0f 
GH-Issue: #3
@felixge felixge mentioned this issue Jul 11, 2020
Merged
@felixge
Copy link
Owner

felixge commented Jul 11, 2020

@howardjohn good idea, thx : ).

PTAL at #4 and confirm if that's what you had in mind.

felixge added a commit that referenced this issue Jul 12, 2020
@felixge
Merge pull request #4 from felixge/gh-3
66ab7d9 
Default to 30s duration like net/http/pprof
@felixge
Copy link
Owner

felixge commented Jul 12, 2020

Fixed in #4

@felixge felixge closed this as completed Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@felixge @howardjohn