Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider moving cli to different lib #36

Closed
jonschlinkert opened this issue Oct 16, 2015 · 11 comments
Closed

consider moving cli to different lib #36

jonschlinkert opened this issue Oct 16, 2015 · 11 comments

Comments

@jonschlinkert
Copy link
Collaborator

I love using this, but I just realized that it's using meow, and I'm guessing that a good percentage of users like myself probably aren't using the CLI, but the dependency tree for it is absurdly massive. Especially considering this would have zero deps without it.

meow has 48 dependencies in total, this is its flattened dependency tree (along with the number of times each module appears in the tree):

{
  'trim-newlines': 1,
  'redent': 1,
  'strip-indent': 1,
  'get-stdin': 1,
  'indent-string': 1,
  'repeating': 1,
  'is-finite': 1,
  'number-is-nan': 1,
  'read-pkg-up': 1,
  'read-pkg': 1,
  'path-type': 1,
  'pinkie-promise': 4,
  'pinkie': 4,
  'pify': 2,
  'graceful-fs': 2,
  'normalize-package-data': 1,
  'load-json-file': 1,
  'strip-bom': 1,
  'is-utf8': 1,
  'parse-json': 1,
  'error-ex': 1,
  'find-up': 1,
  'path-exists': 1,
  'object-assign': 1,
  'validate-npm-package-license': 1,
  'spdx-expression-parse': 1,
  'spdx-license-ids': 2,
  'spdx-exceptions': 1,
  'spdx-correct': 1,
  'semver': 1,
  'is-builtin-module': 1,
  'builtin-modules': 1,
  'hosted-git-info': 1,
  'minimist': 1,
  'loud-rejection': 1,
  'camelcase-keys': 1,
  'map-obj': 1,
  'camelcase': 1
}
@jonschlinkert
Copy link
Collaborator Author

ping, I'd be happy to do a pr to remove this dependency. Unfortunately this shows up every time we install a gulp plugin that uses gulp-util, so it's creating a ton of extra files that aren't needed.

@loheander
Copy link

Great idea, also getting a lot of extra files when installing via npm. Perhaps a separate dateformat-cli package depending on this?

@loheander
Copy link

I have now published a new npm package "dateformat-light" that removes the CLI, and fixes the AMD inclusion bug

@jonschlinkert
Copy link
Collaborator Author

well, I'm a fan of small modules, but that doesn't really solve this issue though, since there are many gulp plugins using gulp-util, and gulp-util uses this lib. The issue will need to be resolved here unfortunately

@jonschlinkert
Copy link
Collaborator Author

fwiw, since this library is no longer supported, I'll be using dateformat-light going forward.

@jonschlinkert
Copy link
Collaborator Author

@felixge can I please get you to consider removing meow from deps?

@felixge
Copy link
Owner

felixge commented Jun 19, 2016

@jonschlinkert send a PR and I'll merge it. Ping me in the PR, I don't watch this repo.

@jonschlinkert
Copy link
Collaborator Author

Great thanks!

@MarkHerhold
Copy link

MarkHerhold commented Jun 19, 2016

Thanks for working on this @jonschlinkert! Please keep us posted.

@jonschlinkert
Copy link
Collaborator Author

no prob, I'll be sending a pr tomorrow (Monday)

@chase-manning
Copy link
Collaborator

Closing as meow is now removed as a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants