-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removes CLI #53
removes CLI #53
Conversation
As per #36 (comment) - ping @felixge |
thanks @phated, good memory! |
This breaks bin/cli.js. Please fix it or remove it as well. |
No problem, I thought that was removed. will do it now |
@jonschlinkert LGTM. What's your npm user name? I'll add you as a repo contributor and npm owner so you can publish this change yourself. |
great, thanks! it's the same, |
@felixge ping, just a reminder to add me to npm, thx! |
@jonschlinkert done. sorry for delay |
thanks! much appreciated. |
@jonschlinkert Did you manage to get the access you need for this? |
@MarkHerhold yes. however, I'd like some feedback before I do this. The main issue I'm hoping to resolve is that every install of gulp comes with ~48 extra deps that don't do anything at all but take up space. This is not the end of the world by any means, but removing these could make installations that much faster. To get to the point, if I publish this as a major (which I would normally do), the problem I'm hoping to solve won't be solved - unless we can bump this in gulp-util as well, which is locked afaik. @phated would you be willing to make an exception and bump this one module in gulp-util? Or do you have a suggestion on how we can do this so that dateformat gets a proper bump, and we also remove these extra deps from gulp-util? |
Yeah, I can bump it. |
Yea, let's create |
awesome! I'll do this tonight. @phated want me to do a pr to bump, or do you want to do it? thanks, I really appreciate it. |
@felixge looks like I don't have write access to the repo, so I can't merge. |
@jonschlinkert Do we also want to squeeze in #40? Just being opportunistic... ;) |
@MarkHerhold that makes sense. If we're going to do a major, that looks like low-hanging fruit. Although I should quell any more opportunism by saying that I won't have much more time to review other prs atm. |
@jonschlinkert fine by me! |
@jonschlinkert feel free to submit a PR on gulp-util |
no prob, once we get this resolved I'll create a pr, thx |
@jonschlinkert Just curious where things stand. Thanks. |
@felixge ping |
@jonschlinkert added you. If you give me your NPM user handle, I'll add you there as well. |
thanks! my username is edit: actually you already added me to npm, just double-checked. thanks again! |
@jonschlinkert added you on npm as well. |
Since the cli was added as a patch bump, I think this should just be a patch bump. Also, the module's api hasn't changed (which is the main use case). I think it'll save other people's time too, since they won't have to explicitly update anything. |
Related to #36.
Thanks! (and sorry for taking so long)