Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed URL by temporary credentials from an IAM role #5

Merged
merged 2 commits into from
Aug 25, 2017
Merged

Signed URL by temporary credentials from an IAM role #5

merged 2 commits into from
Aug 25, 2017

Conversation

dud225
Copy link
Contributor

@dud225 dud225 commented Jul 22, 2016

Generation of a signed URL by temporary credentials provided by an IAM role

Uses case might be scarce as the provided credentials are only valid for 6 hours from the moment they have been generated by AWS : https://forums.aws.amazon.com/thread.jspa?threadID=153786

This PR may probably not be merged but, well we passed half a day working on this so I'd like to share this here though in case it could be be helpful for some people one day.

@dud225 dud225 changed the title Feature/temporary creds iamrole Signed URL by temporary credentials from an IAM role Jul 22, 2016
@felixge
Copy link
Owner

felixge commented Jul 25, 2016

@dud225 thanks for this and #4 . I'll need some time to test this and make sure it works with my custom domain and everything.

@dud225
Copy link
Contributor Author

dud225 commented Aug 24, 2017

@felixge you may already have noticed, this feature has been added in awscli

@felixge felixge merged commit 96539ef into felixge:master Aug 25, 2017
@felixge
Copy link
Owner

felixge commented Aug 25, 2017

@dud225 I stopped using this script on my end, so I'm happy to merge all your PRs. I merged this one, but the other ones have a merge conflict now. If you're interested in updating them, I'll be happy to merge them as well. Sorry for being unresponsive on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants