Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash_storage: compare values in equality operator #215

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

opera-aberglund
Copy link
Contributor

@opera-aberglund opera-aberglund commented Apr 21, 2024

Resolves #214

The equality operator for hash maps should compare both keys and mapped values, not just the keys.

@felixguendling
Copy link
Owner

Maybe GetValue(*it) works? (didn't try)

@opera-aberglund
Copy link
Contributor Author

Maybe GetValue(*it) works? (didn't try)

Updated, try building again?

@felixguendling felixguendling merged commit e5602b8 into felixguendling:master Apr 21, 2024
10 checks passed
@felixguendling
Copy link
Owner

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash_storage equality operator doesn't compare values
2 participants