Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL not appearing in log issue #68

Closed
wants to merge 3 commits into from

Conversation

Ed-Bread
Copy link

Related to #67

After some digging I found that this issue was not happening on version 5 of laadr.
After comparing the two: v5.1.6...v6.1.1
I found that this line:

assign('url', data => (	
  data.req && data.req.url
))

was changed to this:

assign('url', data => (
  data.req && data.req.url && data.req.url.href
))

When I change it back i get the desired output
Screen Shot 2020-10-22 at 10 48 11 AM

@felixheck
Copy link
Owner

first, thanks a ton for using and (way more appreciated) contributing to this module.
Can't get my head around it currently, but I'm sure there was a good reason for doing that.

Would you mind covering both things in your PR?
If data.req.url is an object, return data.req.url.href, otherwise data.req.url.

Happy to merge/publish it asap.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 98.276% when pulling 9d34723 on Bravo-Bear:patch-1 into dfc458b on felixheck:master.

@Ed-Bread
Copy link
Author

Hey Felix, thanks for responding so quickly, I added the logic that you mentioned. Let me know what you think

@felixheck
Copy link
Owner

thanks 😊 will be published within the next hour together we the other open PRs.

@felixheck felixheck closed this Oct 22, 2020
@felixheck
Copy link
Owner

publish as v6.1.2 — sorry for the delay & thanks for your contribution 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants