Fix MSDFText call to translate() for newer versions of three.js and clean up to be deprecated function calls #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o translate function call. Update examples to use renderer.outputColorSpace instead of renderer.outputEncoding and remove "Buffer" from various Geometry instantiations as all geometries are now BufferGeometries. Fix broken links from images in README. Use mergeGeometries instead of the to be deprecated mergeBufferGeometries from BufferGeometryUtils.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for the following updates to play nicely with newer versions of three.js
This should address the following issues