add null check when job is undefined #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikengervall
suggested changes
Oct 22, 2020
| @@ -70,7 +70,7 @@ module.exports = async function getDataForQeues({ queues, query = {} }) { | |||
| return { | |||
| name, | |||
| counts, | |||
| jobs: jobs.map(formatJob), | |||
| jobs: jobs.filter((job) => !!job).map(formatJob), | |||
There was a problem hiding this comment.
A reduce instead of a filter -> map would reduce the iteration count by up to 2x 🙂
I'd recommend going with that instead for this case!
There was a problem hiding this comment.
return {
name,
counts,
jobs: jobs
.reduce((result, job) => {
if (job) {
result.push(formatJob(job))
}
return result
}, [])
}
There was a problem hiding this comment.
I don't agree with you, this consumes 2x memory, it is better to use filter & map as it is more declarative
|
To avoid this error for now you can remove |
robman87
added a commit
to robman87/bull-board
that referenced
this pull request
Nov 25, 2020
This was referenced Nov 25, 2020
felixmosh
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a case where bull returns
nullfor a job. I am not sure why bull does that but this PR adds a null check to prevent the app from crashingfixes #43