EcsResource: Record log group without trailing :*

Both with and without trailing `:*` are valid formats but there is a bug in the OpenTelementry collector which can’t handle the trailing `:*` (for now) (see open-telemetry/opentelemetry-collector-contrib#13702) So remove addition of the trailing `:*` for now.
felixscheinost · Aug 30, 2022 · 1fc24b4 · 1fc24b4
1 parent 57cd334
commit 1fc24b4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/...extensions/aws/src/main/java/io/opentelemetry/sdk/extension/aws/resource/EcsResource.java b/...extensions/aws/src/main/java/io/opentelemetry/sdk/extension/aws/resource/EcsResource.java
@@ -202,8 +202,7 @@ Optional<String> getLogGroupArn() {
         return Optional.empty();
       }
 
-      return Optional.of(
-          "arn:aws:logs:" + region + ":" + account + ":log-group:" + logGroupName + ":*");
+      return Optional.of("arn:aws:logs:" + region + ":" + account + ":log-group:" + logGroupName);
     }
 
     Optional<String> getLogStreamArn() {

diff --git a/...nsions/aws/src/test/java/io/opentelemetry/sdk/extension/aws/resource/EcsResourceTest.java b/...nsions/aws/src/test/java/io/opentelemetry/sdk/extension/aws/resource/EcsResourceTest.java
@@ -104,7 +104,7 @@ void testCreateAttributesV4() throws IOException {
             entry(
                 ResourceAttributes.AWS_LOG_GROUP_ARNS,
                 Collections.singletonList(
-                    "arn:aws:logs:us-west-2:111122223333:log-group:/ecs/metadata:*")),
+                    "arn:aws:logs:us-west-2:111122223333:log-group:/ecs/metadata")),
             entry(
                 ResourceAttributes.AWS_LOG_STREAM_NAMES,
                 Collections.singletonList("ecs/curl/8f03e41243824aea923aca126495f665")),