Skip to content

Commit

Permalink
EcsResource: Record log group without trailing :*
Browse files Browse the repository at this point in the history
Both with and without trailing `:*` are valid formats but there is a bug in the OpenTelementry collector which can’t handle the trailing `:*` (for now) (see open-telemetry/opentelemetry-collector-contrib#13702)

So remove addition of the trailing `:*` for now.
  • Loading branch information
felixscheinost committed Aug 30, 2022
1 parent 57cd334 commit 27edbd8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ Optional<String> getLogGroupArn() {
}

return Optional.of(
"arn:aws:logs:" + region + ":" + account + ":log-group:" + logGroupName + ":*");
"arn:aws:logs:" + region + ":" + account + ":log-group:" + logGroupName);
}

Optional<String> getLogStreamArn() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ void testCreateAttributesV4() throws IOException {
entry(
ResourceAttributes.AWS_LOG_GROUP_ARNS,
Collections.singletonList(
"arn:aws:logs:us-west-2:111122223333:log-group:/ecs/metadata:*")),
"arn:aws:logs:us-west-2:111122223333:log-group:/ecs/metadata")),
entry(
ResourceAttributes.AWS_LOG_STREAM_NAMES,
Collections.singletonList("ecs/curl/8f03e41243824aea923aca126495f665")),
Expand Down

0 comments on commit 27edbd8

Please sign in to comment.