-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for prosemirror.model #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p7g
reviewed
Jun 16, 2023
p7g
reviewed
Jun 16, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
+ Coverage 82.63% 83.07% +0.44%
==========================================
Files 30 30
Lines 3870 4148 +278
==========================================
+ Hits 3198 3446 +248
- Misses 672 702 +30 ☔ View full report in Codecov by Sentry. |
p7g
approved these changes
Jun 16, 2023
ernesto-at-fellow
approved these changes
Oct 20, 2023
…m the typing module if possible.
…class (just like in the original prosemirror repo).
…o override the strict option for some modules (python/mypy#11401).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been chipping away at this over the past few days. Most of the types came from using monkeytype, then some manual updates to change code to match upstream which wasn't caught with the switchover to TypeScript.
This also uncovered a few bugs that were not identified by tests:
After this it would be nice to add some types from prosemirror.transform, as well as switch a few things over to dataclasses, and maybe experiment with compilation with mypyc... 👀