Double MSDF #5
Open
Double MSDF #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
8 tasks
ibesora
force-pushed
the
ib/final-double-msdf
branch
from
379ecef
to
80e83db
Compare
ChrisLoer
reviewed
Sep 10, 2024
| float size = v_data1.y; | ||
| float fade_opacity = v_data1[2]; | ||
|
|
||
| fragColor = u_is_text || !u_is_msdf ? renderText(u_is_text, fill_color, halo_color, opacity, halo_width, halo_blur, EDGE_GAMMA, tex, gamma_scale, size, fade_opacity) : renderMSDFIcon(fill_color, halo_color, opacity, EDGE_GAMMA, tex, gamma_scale, size, fade_opacity); |
There was a problem hiding this comment.
I expressed concern about this branching logic in our 1:1, but I think since the input to the branch is a uniform the execution only ever has to follow one path and there ends up not being any efficiency hit.
ChrisLoer
reviewed
Sep 10, 2024
|
|
||
| float EDGE_GAMMA = 0.105 / u_device_pixel_ratio; | ||
| float screenPxRange(float fontScale) { | ||
| // WebGL1 doesn't support derivatives and we can't use version 300 |
There was a problem hiding this comment.
I think this comment is a little confusing because it doesn't say why we'd want to support derivatives? i.e. what the preferred code would be and why it would be better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements VIZ-1182
I've added changes by commits:
Test plan: