Rewrite webpack config to generate umd library #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Oct 2, 2017
| @@ -1,2 +1,2 @@ | |||
| node_modules | |||
| dist/ | |||
| .idea | |||
daurnimator
reviewed
Oct 2, 2017
| "scripts": { | ||
| "build": "webpack" | ||
| } | ||
| "name": "fengari-interop", |
There was a problem hiding this comment.
Please don't change indentation (especially of existing files; and especially not as part of another commit)
|
As mentioned in fengari-lua/fengari#90 I do not think it is good practice to include build artifacts in a repository. |
|
No longer needed with fengari-lua/fengari-web#20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the webpack config completely (similarly to fengari-lua/fengari#90) to make the library work with Webpack and create-react-app. Fengari is also built as an external to save space.