fix: add rounded option to the getCroppedCanvas method (#551)
#1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7anshuai
force-pushed
the
fix/1px-black-line
branch
2 times, most recently
from
044a7f1
to
c2946c5
Compare
7anshuai
changed the title
rounded option to getCroppedCanvas method (#551)rounded option to the getCroppedCanvas method (#551)
gtteamamxx
reviewed
Jul 27, 2023
src/js/methods.js
Outdated
| @@ -654,7 +654,7 @@ export default { | |||
| y: initialY, | |||
| width: initialWidth, | |||
| height: initialHeight, | |||
| } = this.getData(); | |||
| } = this.getData(options.rounded || false); | |||
7anshuai
force-pushed
the
fix/1px-black-line
branch
from
c2946c5
to
68e80ee
Compare
This was referenced May 20, 2024
This was referenced May 27, 2024
This was referenced Jun 3, 2024
This was referenced Aug 11, 2024
This was referenced Aug 18, 2024
This was referenced Aug 26, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: