-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Chrome: Long press on .cropper-container triggers unexpected behavior #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2024
This was referenced May 27, 2024
This was referenced Jun 3, 2024
This was referenced Jun 11, 2024
This was referenced Jun 18, 2024
This was referenced Sep 4, 2024
This was referenced Sep 7, 2024
This was referenced Sep 14, 2024
This was referenced Sep 21, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On iOS Chrome, after long-pressing on the cropper container area which makes the context menu pop up, only the pan gesture can be recognized, and other gestures don't work. And the pan gesture now only scales the image instead of moving it like it was. You can see it in the video below.
RPReplay_Final1711422308.mov
Right now, the solution we found is adding "-webkit-touch-callout: none;" to the ".cropper-container" class selector.
If you'd like to apply this change, please review my pull request and merge it if there are no problems. Thanks!
What kind of change does this PR introduce? (check at least one)
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: