Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI does not check for conflicting settings #1

Open
fenhl opened this issue May 4, 2022 · 0 comments
Open

CLI does not check for conflicting settings #1

fenhl opened this issue May 4, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@fenhl
Copy link
Owner

fenhl commented May 4, 2022

With OoTRandomizer#1531 and OoTRandomizer#1536, the forest settings now rely on the disable relations in the settings list rather than silently changing. This works fine with plando and the GUI, but when specifying settings through the CLI (or the ootrandomizer.com API, which I believe uses the CLI internally), no such check is performed, resulting in some settings missing from the spoiler log.
@fenhl fenhl added the bug Something isn't working label May 4, 2022
fenhl pushed a commit that referenced this issue Jun 1, 2022
@Jaybone25
Merge pull request #1 from fenhl/ganon-er-fixes
0672e9d 
Quick Ganon ER fixes
fenhl pushed a commit that referenced this issue Jun 15, 2022
@dotzo
Merge pull request #1 from DobbyDigital/patch-1
4e0f851 
Force Path of Magic hint
fenhl pushed a commit that referenced this issue Aug 19, 2022
@Hamsda
Merge pull request #1 from fenhl/less-strict-preset-checks
edeb210 
Don't check for conflicting settings in preset unit tests
fenhl pushed a commit that referenced this issue Oct 20, 2022
@cjohnson57
Merge pull request #1 from denoflionsx/models
fe84538 
Fix hierarchy and pointers
NeunEinser pushed a commit to NeunEinser/OoT-Randomizer that referenced this issue Dec 17, 2022
@GSKirox
Merge pull request fenhl#1 from mracsys/warp-song-models
e811125 
Add inverted music note model for warp songs
fenhl pushed a commit that referenced this issue Jan 30, 2023
@engineer124
Merge pull request #1 from fenhl/blue-warp-item-override
4edda81 
Allow shuffled items on dungeon reward locations
fenhl pushed a commit that referenced this issue Mar 6, 2023
@Elagatua
Merge pull request #1 from Elagatua/feature/triforce-blitz-rebase
d5344d1 
Triforce blitz v0.1
fenhl pushed a commit that referenced this issue Mar 18, 2023
@AngheloAlf
Merge pull request #1 from fenhl/conditional-heart-chest-textures
99b3f9f 
Heart chest size conditional
fenhl pushed a commit that referenced this issue Jun 20, 2023
@Maplesstar
Merge pull request #1 from mracsys/optional-key-models
90ec367 
make custom key models a setting
fenhl pushed a commit that referenced this issue Sep 17, 2023
@owlisnotacat1
Merge pull request #1 from rrealmuto/owl_fanfare_fix
41d2ca0 
Make fanfare fix compatible with ROMs that don't support custom banks
fenhl pushed a commit that referenced this issue Jul 15, 2024
@shirosoluna
Merge pull request #1 from shirosoluna/shirosoluna-patch-1
07a4304 
CI fixes
fenhl pushed a commit that referenced this issue Oct 1, 2024
@aofengen
Merge pull request #1 from fenhl/settings-list-reorder
c066509 
Reorder SettingsList.py to match GUI changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fenhl