Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for new apple m1 processor - implemented as a fallback - … #119

Closed
wants to merge 1 commit into from
Closed

add support for new apple m1 processor - implemented as a fallback - … #119

wants to merge 1 commit into from

Conversation

sakes
Copy link

@sakes sakes commented Mar 19, 2022

…source of bug: lib bin-wrapper is unable to identify arch for new apple m1

…source of bug: lib bin-wrapper is unable to identify arch for new apple m1
@sakes
Copy link
Author

sakes commented Mar 19, 2022

@XhmikosR, here is the pr as requested. I executed npm test on my M1 and it passed.

#118

@XhmikosR
Copy link
Collaborator

XhmikosR commented Mar 19, 2022

This breaks things for other macOS arches as you can see by the tests... Also, it doesn't seem right to me because there's a check for unsupported OS/arch which this will bypass?

@sakes
Copy link
Author

sakes commented Mar 19, 2022

Strange, worked locally. Well, in order to find a fix (too bad not working) I had to dig into bin-wrapper's code, fix a bunch of lint errors to get the tests to run, and then confirmed it was returning undefined for my arch.

I would have attempted to fix the issue in bin-wrapper, but it appears it was abandoned 3 years ago, so i attempted to solve here.

Sadly, i threw away my changes for bin-wrapper, and am out of time this weekend.

I'll try to give it another go next weekend.

@sakes
Copy link
Author

sakes commented Mar 19, 2022

Declining as some CI tests failed.

@sakes sakes closed this Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants