Rebased

fennel-ai · Sep 6, 2024 · 760113d · 760113d
1 parent a0084e8
commit 760113d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 175 deletions.
diff --git a/fennel/datasets/test_dataset.py b/fennel/datasets/test_dataset.py
@@ -595,7 +595,7 @@ class ABCDataset:
         @includes(add_one)
         @inputs(A, B)
         def pipeline1(cls, a: Dataset, b: Dataset):
-            return a.join(b, how="left", left_on=["a1"], right_on=["b1"])
+            return a.join(b, how="inner", left_on=["a1"], right_on=["b1"])
 
     view = InternalTestClient()
     view.add(ABCDataset)
@@ -637,14 +637,14 @@ def add_one(x: int):
 @includes(add_one)
 @inputs(A, B)
 def pipeline1(cls, a: Dataset, b: Dataset):
-    return a.join(b, how="left", left_on=["a1"], right_on=["b1"])
+    return a.join(b, how="inner", left_on=["a1"], right_on=["b1"])
 """
     assert expected_gen_code == pipeline_req.pycode.generated_code
     expected_source_code = """@pipeline
 @includes(add_one)
 @inputs(A, B)
 def pipeline1(cls, a: Dataset, b: Dataset):
-    return a.join(b, how="left", left_on=["a1"], right_on=["b1"])
+    return a.join(b, how="inner", left_on=["a1"], right_on=["b1"])
 """
     assert expected_source_code == pipeline_req.pycode.source_code
     p = {
@@ -696,7 +696,7 @@ def pipeline1(cls, a: Dataset, b: Dataset):
     )
     operator_req = sync_request.operators[2]
     o = {
-	    "id":"3338ee30aac1dc899789da9fc78fa025",
+	    "id":"b8a998fc5e47160f2ef4d3e4570d6bab",
 	    "isRoot":True,
 	    "pipelineName":"pipeline1",
 	    "datasetName":"ABCDataset",
@@ -705,7 +705,8 @@ def pipeline1(cls, a: Dataset, b: Dataset):
 	        "rhsDsrefOperandId":"B",
 	        "on":{
 	            "a1":"b1"
-	        }
+	        },
+            "how":"Inner"
 	    },
 	    "dsVersion":1
 	}