lambda: Fix bug for using lambdas in jupyter notebook #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev |
bothra90
approved these changes
Sep 17, 2024
| lines = f.readlines() | ||
| if line_num < len(lines): | ||
| next_line = lines[line_num].strip() | ||
| except Exception: |
There was a problem hiding this comment.
Can you add a comment for when we expect the exception to happen what we're trying to do? Is the behavior desirable in general or only if we're operating in a notebook environment? If the latter, can we somehow check for that if this is not always the right thing to do?
aditya-nambiar
force-pushed
the
aditya/lambda-notebook
branch
from
92ad425
to
86e6dab
Compare
aditya-nambiar
force-pushed
the
aditya/lambda-notebook
branch
from
86e6dab
to
ca410f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.