Port qt6 #1
Open
Port qt6 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochurlaud
commented
Feb 23, 2024
And remove Qt5 only code
…int,int,int,int) idem for getMargin
|
Compiled and tested on Linux: it plays remote music and can read streams (I don't use everything so someone should make some deeper tests). The connections to wikipedia and co work fine. |
|
@fenuks do you think you would test and merge in your repo, or should I merge that to my "main" branch ? |
|
Yes, thank you for the effort. I was planning to do Qt6 migration myself soon, because I am already using Plasma 6. I will try to check your code this weekend. |
|
I've also been doing some work on nullobsi/cantata to modernize the build scripts based on this PR. |
|
@fenuks any news ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll cleanup when it compiles and when I can test it (compilation: 100%, linking fails)