Implement SAFT-VR Mie equation of state #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prehner
reviewed
Apr 16, 2024
|
|
||
| use super::SaftVRMieParameters; | ||
| use association::Association; | ||
| use feos_core::{ |
There was a problem hiding this comment.
not a major issue, but I feel like this default setting of how rust-analyzer does imports is one of the weaker decisions they made. I know you can configure it, but is there a way to do it workspace-specific and include the config file in GitHub?
|
Also, you might want to add an entry in model matrix in workflows/test.yml |
prehner
reviewed
Apr 17, 2024
…ed vr mie benches, removed fmt from Cargo.toml
prehner
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not covered in this PR