Update gauss-quad to 0.2
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-bauer
approved these changes
Nov 24, 2024
|
Thank you for the contribution! Looks good to me, happy to merge when the CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I saw that yours is a big project that uses the crate
gauss-quadthat I am one of the maintainers of. We recently released version 0.2 that restructures the API. This PR updatesgauss-quadas well as the two call sites to the new version so that you don't have to.The main difference this PR introduces into your code is that it removes one computation of the nodes and weights and makes a previously hidden panic and allocation explicit.
As this is an unsolicited PR i understand completely if it is not something you are interested in.