fix: support chinese for enum #1913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ferdikoomen review |
| @@ -20,7 +20,7 @@ export const getEnum = (values?: (string | number)[]): Enum[] => { | |||
| } | |||
| return { | |||
| name: String(value) | |||
| .replace(/\W+/g, '_') | |||
| .replace(/[^a-zA-Z0-9_\u4e00-\u9fa5]+/g, '_') | |||
There was a problem hiding this comment.
If the name is used as an identifier, the correct characters to include would be the ones with the ID_Start or ID_Continue Unicode property. The CJK characters in the BMP with ID_Start are currently \u3400-\u4DBF\u4E00-\u9FFF\uF900-\uFAD9.
It could also make sense to already allow all characters with the correct Unicode properties, though that would probably require a dependency to pull off.
|
I had a similar need to support nordic characters, so based on @PetrusAsikainen's mdn link about identifiers above, I've created another PR that I believe handles all valid identifier characters: #2038 Maybe that could be merged instead of this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support chinese string for enum