-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix notifications on all services #1593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecialAro
changed the title
Fix notifications on all services
WIP: Fix notifications on all services
Feb 25, 2024
vraravam
reviewed
Feb 26, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
Apr 30, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
Apr 30, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 3, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 3, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 3, 2024
Self-reminder: This PR should also address the issue here (#1751) that was introduced by the |
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 8, 2024
SpecialAro
force-pushed
the
fix-notifications
branch
from
May 11, 2024 01:27
ff10ffc
to
1d7b20a
Compare
SpecialAro
changed the title
WIP: Fix notifications on all services
Fix notifications on all services
May 11, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 13, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 13, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 13, 2024
ponces
pushed a commit
to ponces/ferdium-app
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Change notification class to extend
window.Notification
.Motivation and Context
Several users are reporting that notifications don't work on several services (noticed that
icon
was not being shown properly)Maybe fixes #1105
Fixes #1751
Fixes #1747
Fixes #896
Fixes #1719
Fixes #1652
Steps to fix this PR:
and go to the corresponding message on a service (new feature). (I was not able to implement this last logic... it's rather complex. Leaving for the future).Checklist
pnpm prepare-code
)pnpm test
passesRelease Notes
Fixed several issues with notifications (double notifications, no icons on notification, content showing when private).
Added feature to open Ferdium and go to the specific service after clicking the notification.