Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron to '30.0.0' #1688

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

vraravam
Copy link
Contributor

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade electron to newest public release

Motivation and Context

Changelog

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam self-assigned this Apr 16, 2024
@vraravam
Copy link
Contributor Author

vraravam commented Apr 16, 2024

Whoever is reviewing, please run the app locally on different OSes and check.
Once your testing is done, please check the appropriate checkbox below (or add a new comment)

  • Tested on macos (m1) - Vijay
  • Tested on macos (intel) - Vijay
  • Tested on windows (11) - SpecialAro
  • Tested on linux (Fedora 39) - SpecialAro

@vraravam vraravam marked this pull request as ready for review April 16, 2024 09:54
@SpecialAro
Copy link
Member

SpecialAro commented Apr 16, 2024

image

Working fine on Windows 11 😄 Thank you!

@SpecialAro
Copy link
Member

image

Working fine on Linux (Fedora 39) as well - though, I had to comment out stuff (and return false) on the dnd.ts file (it wouldn't go past the typescript lint on the macos dependency). Nevertheless, I think we are good :D

@vraravam vraravam merged commit 90a2029 into ferdium:develop Apr 16, 2024
5 checks passed
@vraravam vraravam deleted the electron-30.0.0 branch April 16, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants