Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pnpm to 9.1.4 #1795

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Upgrade pnpm to 9.1.4 #1795

merged 1 commit into from
Jun 2, 2024

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jun 1, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Upgrade pnpm to 9.1.4

Motivation and Context

From @Alphrag : A few things that I have seen that are good in it: it uses node-gyp v10.x which means rebuilding some dependencies won't fail (like sqlite3 if we wish at one point to upgrade it again to the latest version, but is not recommended atm), and allows shorter paths of included node-modules for windows which could fix a problem for some users

Screenshots

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam
Copy link
Contributor Author

vraravam commented Jun 1, 2024

Will need to wait for the next nightly so that other fixes can be released as a nightly. After which, we need to merge this PR, and finally upgrade the recipes submodule with the latest, and then test this PR

@Alphrag
Copy link
Member

Alphrag commented Jun 1, 2024

All good on Windows!
image

@vraravam vraravam marked this pull request as ready for review June 2, 2024 02:52
@vraravam vraravam merged commit 4c6f594 into ferdium:develop Jun 2, 2024
5 checks passed
@vraravam vraravam deleted the pnpm-9.1.4 branch June 2, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants