Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get confirmation before deleting a service in EditServices screen #1853

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

vraravam
Copy link
Contributor

@vraravam vraravam commented Jul 16, 2024

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Fixes #1852

Motivation and Context

Screenshots

Screenshot 2024-07-16 at 3 14 06 PM

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

@vraravam vraravam requested a review from a team July 16, 2024 09:43
@vraravam vraravam self-assigned this Jul 16, 2024
@vraravam vraravam merged commit db2f325 into ferdium:develop Jul 16, 2024
5 checks passed
@vraravam vraravam deleted the delete-service-confirmation branch July 16, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confirmation on the Delete service action in the service settings form
1 participant