Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade electron-builder, electron-updater and electron/notarize #1924

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Upgrade electron-builder, electron-updater and electron/notarize #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08c3972
Update electron-builder and electron-updater
Alphrag Oct 12, 2024
ab8adbf
Upgrade notarize
Alphrag Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# 'FERDIUM_PUBLISH_TOKEN' (A GitHub Personal Access Token with appropriate permissions - for publishing the built artifacts)
# 'APPLEID' (The username of your Apple developer account - for notarizing the mac artifacts)
# 'APPLEID_PASSWORD' (An app-specific password - for notarizing the mac artifacts)
# 'APPLE_TEAM_ID' (The TeamID in your Apple developer account - for notarizing the mac artifacts)
# 'CSC_LINK' (The HTTPS link or local path to certificate - for code signing of mac artifacts)
# 'CSC_KEY_PASSWORD' (The password to decrypt the certificate given in CSC_LINK - for code signing of mac artifacts)
# 'WIN_CSC_LINK' (The HTTPS link or local path to certificate - for code signing of windows artifacts)
Expand Down Expand Up @@ -200,6 +201,7 @@ jobs:
CSC_IDENTITY_AUTO_DISCOVERY: true
APPLEID: ${{ secrets.APPLEID }}
APPLEID_PASSWORD: ${{ secrets.APPLEID_PASSWORD }}
APPLE_TEAM_ID: ${{ secrets.APPLE_TEAM_ID }}
CSC_LINK: ${{ secrets.CSC_LINK }}
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
run: pnpm build --publish always
Expand Down
3 changes: 1 addition & 2 deletions build-helpers/notarize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ exports.default = async function notarizing(context) {
const { notarize } = require('@electron/notarize');

await notarize({
tool: 'notarytool',
appPath: `${appOutDir}/${appName}.app`,
teamId: '55E9FPJ93P',
teamId: process.env.APPLE_TEAM_ID || '',
appleId: process.env.APPLEID || '',
appleIdPassword: process.env.APPLEID_PASSWORD || '',
});
Expand Down
5 changes: 3 additions & 2 deletions electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,9 @@ win:
arch: [x64, ia32, arm64]
- target: portable
arch: [x64, ia32, arm64]
# The name of the CN appearing in the certificate must be present in the publisherName list below
publisherName: ["Ferdium Contributors", "Ambroise Grau"]
signtoolOptions:
# The name of the CN appearing in the certificate must be present in the publisherName list below
publisherName: ["Ferdium Contributors", "Ambroise Grau"]
# Remove the verification for a signature to allow auto-update without signed certificate
verifyUpdateCodeSignature: false

Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"electron-dl": "3.5.2",
"electron-find": "1.0.7",
"electron-react-titlebar": "1.2.1",
"electron-updater": "6.2.1",
"electron-updater": "6.4.0-alpha.0",
vraravam marked this conversation as resolved.
Show resolved Hide resolved
"electron-window-state": "5.0.3",
"fast-folder-size": "2.2.0",
"fs-extra": "11.2.0",
Expand Down Expand Up @@ -135,7 +135,7 @@
"@biomejs/biome": "1.6.1",
"@commitlint/cli": "19.3.0",
"@commitlint/config-conventional": "19.2.2",
"@electron/notarize": "2.3.2",
"@electron/notarize": "2.5.0",
"@eslint-react/eslint-plugin": "1.5.12",
"@formatjs/cli": "6.2.12",
"@jest/types": "29.6.3",
Expand Down Expand Up @@ -164,7 +164,7 @@
"concurrently": "8.2.2",
"cross-env": "7.0.3",
"electron": "32.2.0",
"electron-builder": "24.13.3",
"electron-builder": "26.0.0-alpha.1",
vraravam marked this conversation as resolved.
Show resolved Hide resolved
"esbuild": "0.16.17",
"esbuild-plugin-copy": "2.1.1",
"esbuild-runner": "2.2.2",
Expand Down
Loading
Loading