Revert "Upgrade electron-builder, electron-updater" #1927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #1924
Reason for the revert
Despite the app building and launching from a clean state, it appears that there is then a problem when the internal server starts, with some dependencies missing. In particular, the module
color-stringneeded byadonisjsis not included, as can be seen from the inspection of the.asarfile: (where the top tree correspond to the asar when usingelectron-builderversion26.0.0-alpha, and the bottom one to what we have in the working version built with version24.13.3)Despite multiple attempts to fix this, the problem is deeper than expected. We are reverting the upgrade of
electron-builderandelectron-updaterin order to avoid breaking the app on the next triggered nightly.Changes kept
The upgrade of
@electron/notarizetogether with the passing of theteamIdvalue necessary during notarization into an environment variable.