Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to use Alt+[0-9] to select service #1972

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

dxrcy
Copy link
Contributor

@dxrcy dxrcy commented Nov 18, 2024

Closes #1971, and shares similarity with #1920

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Add an option to Settings > Advances > Shortcuts to use Alt modifier (instead of Ctrl) to select current service with number keys.
The input is unchecked by default. If the input is checked, the user cannot use Ctrl+[0-9] to activate a service, but instead must use Alt+[0-9] (similar to Firefox). This does not impact users who do not manually enable the feature.

I have placed the toggle option below the shortcut inputs implemented by #1920 because it seems the most appropriate location. Likewise the state is stored in stores.shortcuts. This can of course be changed if deemed necessary.

Motivation and Context

I use Firefox, so I am accustomed to using Alt+[0-9] to switch tabs (rather than Ctrl+[0-9]).
Closes #1971 by implementing the second proposed solution (issue provides 3 possible solutions).

Screenshots

image

Checklist

  • My pull request is properly named
  • The changes respect the code style of the project (pnpm prepare-code)
  • pnpm test passes
  • I tested/previewed my changes locally

Release Notes

Add option to use Alt+[0-9] to select service.

@dxrcy dxrcy marked this pull request as ready for review November 18, 2024 01:57
@dxrcy dxrcy changed the title Add option to use Alt+[0-9] to activate services feat: option to use Alt+[0-9] to select service Nov 19, 2024
Copy link
Contributor

@vraravam vraravam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vraravam vraravam merged commit 57e41c5 into ferdium:develop Nov 29, 2024
5 checks passed
@vraravam
Copy link
Contributor

@all-contributors please add @dxrcy for code

Copy link
Contributor

@vraravam

I've put up a pull request to add @dxrcy! 🎉

@zeroknots
Copy link

Is there any chance we can get this for ctrl as well?

@dxrcy
Copy link
Contributor Author

dxrcy commented Dec 5, 2024

Is there any chance we can get this for ctrl as well?

Not sure what you mean exactly. Ctrl is the default modifier currently. Unless you are using Mac?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Customize shortcuts for selecting services
3 participants