Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @adonisjs/ace from 5.1.0 to 11.3.1 #883

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 16, 2023

Bumps @adonisjs/ace from 5.1.0 to 11.3.1.

Release notes

Sourced from @​adonisjs/ace's releases.

Use command argument default value when not specified during run

  • chore: update dependencies de3a428
  • fix: retain default value assigned to arguments on the class instance cf51363
  • chore: update dependencies 619c3bc

adonisjs/ace@v11.3.0...v11.3.1

Share the alias with the command if the command was executed from an alias

  • feat: share aliases defined inside &quot

Fix for recursive imports when generating manifest

  • chore: update dependencies 20c5d96
  • improvement: maintain set of processed files when generating manifest (#143) fa05189
  • test: add tests for optional arguments 55a79db
  • chore: update dependencies b1bc354

adonisjs/ace@v11.2.2...v11.2.3

Add mockConsoleOutput method

This method mocks the logger and prompts and keeps them within the memory for assertions

  • feat: add mockConsoleOutput method to mock prompts and logger 51fc37a

adonisjs/ace@v11.2.1...v11.2.2

Fixing types for 11.20.0

  • fix: types for kernel.exec command d2f5138

adonisjs/ace@v11.2.0...v11.2.1

The "kernel.exec" method now returns the command instance back

  • refactor: return command instance from the exec method 4a311ad

adonisjs/ace@v11.1.0...v11.2.0

Add isMain and isInteractive flags to command instance

Both the flags can make it easier for commands to decide how they should behave when running. For example: The migration commands can close the database when isMain true, otherwise do not close the database connection.

  • feat: add isMain and isInteractive flags to command ba3a707

adonisjs/ace@v11.0.7...v11.1.0

Update dependencies

  • chore: update dependencies cb5164a
  • refactor: migrate to new japa (#142) f7b635c

adonisjs/ace@v11.0.6...v11.0.7

Update dependencies

  • chore: display log colors when publishing package 56d44f4

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [@adonisjs/ace](https://github.com/adonisjs/ace) from 5.1.0 to 11.3.1.
- [Release notes](https://github.com/adonisjs/ace/releases)
- [Changelog](https://github.com/adonisjs/ace/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/adonisjs/ace/commits/v11.3.1)

---
updated-dependencies:
- dependency-name: "@adonisjs/ace"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner January 16, 2023 01:54
@SpecialAro
Copy link
Member

Tested locally on Windows 11 and, as expected, this PR is not ready to be merged as it throws an error when starting the app with pnpm start. Therefore, I'm marking it as draft.

TypeError: ace.addCommand is not a function


1 ValidationProvider.boot
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\@adonisjs+validator@5.1.0\node_modules\@adonisjs\validator\providers\ValidatorProvider.js:124

2 anonymous
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\@adonisjs+fold@4.1.0\node_modules\@adonisjs\fold\src\Registrar\index.js:147

3 arrayMap
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:653

4 Function.map
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:9622

5 interceptor
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:17094

6 thru
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:8859

7 anonymous
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:4430

8 arrayReduce
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:697

9 baseWrapperValue
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:4429

10 LazyWrapper.lazyValue [as value]
  C:\Users\SpecialAro\Projects\ferdium\ferdium-app\node_modules\.pnpm\lodash@4.17.21\node_modules\lodash\lodash.js:1901

@SpecialAro SpecialAro marked this pull request as draft January 19, 2023 00:30
@mcmxcdev
Copy link
Contributor

This dependency upgrade cannot be done as long as adonis dependencies in ferdium-server are not upgraded.

In-progress PR to track: ferdium/ferdium-server#47

Closing this to clean up the open PRs list and since the actual upgrade on the frontend side wouldn't be automated with dependabot anyway.

@mcmxcdev mcmxcdev closed this Jul 29, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 29, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/adonisjs/ace-11.3.1 branch July 29, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants