-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sonarqube): add recipe #595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haven't tested, but looks good to me
67e398c
to
1dcfcc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YaMoef - looks like the CI run is failing. Most likely due to formatting changes that show up as modified files. Please run the commands locally and fix them before this PR can be approved and merged.
I ran the formatting commands, but I get locally issues with a version bump, is that ok? Or do I need to bump the version? |
you can run the git commit command by bypassing the precommit checks with the |
Perfect, this is what I did when I committed. The PR is good to go on my end :) |
e8aa5c2
to
269f172
Compare
@YaMoef - it is always a good idea to rebase from the latest version of the parent branch ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Added new recipe: SonarQube