Skip to content

Commit

Permalink
[hist] remove default parameter in TH1::GetQuantiles, as is the case …
Browse files Browse the repository at this point in the history
…with TF1::GetQuantiles

Fixes root-project#16784

The currently default parameter of p = nullptr is a very weird use case, which calculates F-1(F(bin_edges)), ie it just returns the bin edges. So force user to really decide if he wants to pass that nullptr as argument.
  • Loading branch information
ferdymercury authored Oct 31, 2024
1 parent df96343 commit 275ae02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hist/hist/inc/TH1.h
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ class TH1 : public TNamed, public TAttLine, public TAttFill, public TAttMarker {

TVirtualHistPainter *GetPainter(Option_t *option="");

virtual Int_t GetQuantiles(Int_t n, Double_t *xp, const Double_t *p = nullptr);
virtual Int_t GetQuantiles(Int_t n, Double_t *xp, const Double_t *p);
virtual Double_t GetRandom(TRandom * rng = nullptr) const;
virtual void GetStats(Double_t *stats) const;
virtual Double_t GetStdDev(Int_t axis=1) const;
Expand Down

0 comments on commit 275ae02

Please sign in to comment.