Update stopwords_ukr.js #329
Conversation
imposeren
force-pushed
the
patch-1
branch
2 times, most recently
from
79736a3 to
2862555
Compare
|
Nice, thanks @imposerene! |
|
Sorry, pushed some more changes. I think that's all for now. But yeah, I saw that tests failed before I pushed again... Will look at what fails and try to fix (maybe I just missed coma somewhere) |
|
Sorry. Used wrong email in my commit (was using work one). Amended to not relate my current company to the commit. Sorry, for slopy commits... |
|
No problem 😊 |
Manually selected top frequency pronounces, conjunctions, adpositions, grammatical particles and adverbs from Ukrainian corpus and added them to stopwords_ukr.js . Also moved some stopwords from the end of the to their alphabetical position: now whole list is more or less in alphabetical order (first letter for sure, second letter I think is also fine, but I did not check all existing words and did not use automatic sorting to minimize the changes)
|
Any suggestions on how to quickly run tests locally? I'm not a JS developer, but if there is an easy way to run under linux or in docker, then I can manage to check the tests locally. I already pushed potential fix (test will now expect "на" adposition to be removed), but would be greate if I could actually run the test locally |
|
All tests are ok after the small fix I introduced earlier |
|
Yes, I saw that. Just one test with a little hickup on cleaning up. So I'll merge and publish! |
|
New version out on npm: https://www.npmjs.com/package/stopword/v/3.1.2 Thanks for the PR, @imposeren ! |
Manually selected top frequency pronounces, conjunctions, adpositions, grammatical particles and adverbs from Ukrainian corpus and added them to stopwords_ukr.js . Also moved some stopwords from the end of the list to their alphabetical position: now whole list is more or less in alphabetical order (first letter for sure, second letter I think is also fine, but I did not check all existing words and did not use automatic sorting to minimize the changes)