Run postgres directly and not via pg_ctl in Linux #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the process dies. Windows behaviour unchanged since it's more involved.
|
I think the only way we're getting this merged is having consistent behaviour for all platforms. The extra code involved means we're moving away from the goal of this library, which is to deliver a consistent testing performance for all platforms. I suspect we could solve the entire problem with some smart test wrappers that caught any panics and ensured a PID was removed if it was left hanging around on all systems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will ensure the process dies. Windows behaviour unchanged since it's more involved.