Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs with bart build lifecycle and added doc for executing #122

Merged
merged 2 commits into from
Sep 6, 2022

Conversation

Ragnyll
Copy link
Contributor

@Ragnyll Ragnyll commented Sep 5, 2022

In #121 I noticed some issues from the quickstart instructions and thought to add a bit of clarification.

@Ragnyll Ragnyll force-pushed the 121_documentation_build_instructions branch from c1a486d to 4447a28 Compare September 5, 2022 19:27
Signed-off-by: ragnyll <ragnyll@gallowzhumour.dev>
Signed-off-by: ragnyll <ragnyll@gallowzhumour.dev>
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the docs fixes/clarifications here @Ragnyll! LGTM.

@vdice vdice merged commit d13100d into fermyon:main Sep 6, 2022
@Ragnyll Ragnyll deleted the 121_documentation_build_instructions branch September 7, 2022 04:16
rajatjindal pushed a commit to rajatjindal/bartholomew that referenced this pull request Sep 8, 2022
…ermyon#122)

* updated docs with bart build lifecycle and added doc for executing

Signed-off-by: ragnyll <ragnyll@gallowzhumour.dev>

* give target path

Signed-off-by: ragnyll <ragnyll@gallowzhumour.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants