Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to specify shortocodes directory from bart #134

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

karthik2804
Copy link
Contributor

Fixes a minor bug where bart check would pass but complain about undefined helpers when shortcodes are used by adding the ability to specify the shortcodes directory using an optional shortcodes flag.

Signed-off-by: Karthik Ganeshram karthik.ganeshram@fermyon.com

Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only thought is adding documentation around this -- but we don't yet have a proper docs section on the bart CLI at all yet, right? Should we create an issue to add bart docs (where this --shortcodes flag could be documented)?

@karthik2804
Copy link
Contributor Author

We do have docs on them. I will update the docs for this change along with this PR.

Signed-off-by: Karthik Ganeshram <karthik.ganeshram@fermyon.com>
@karthik2804 karthik2804 merged commit c602220 into fermyon:main Sep 21, 2022
@karthik2804 karthik2804 deleted the fix/bart-shortcodes branch September 21, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants