Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to embed social #57

Merged
merged 1 commit into from
Apr 7, 2022
Merged

add ability to embed social #57

merged 1 commit into from
Apr 7, 2022

Conversation

rajatjindal
Copy link
Contributor

depends on rajatjindal/handlebars-sprig#2

preview example

Web capture_3-4-2022_235442_localhost

@rajatjindal rajatjindal mentioned this pull request Apr 3, 2022
Closed
@rajatjindal rajatjindal changed the title add ability to embed social [WIP] add ability to embed social Apr 3, 2022
@rajatjindal
Copy link
Contributor Author

build is failing as its referring to local path for handlebars_sprig (new version publishing is pending review)

@rajatjindal rajatjindal changed the title [WIP] add ability to embed social add ability to embed social Apr 4, 2022
@rajatjindal
Copy link
Contributor Author

this is ready for review. it adds embedding for tweet and gist. working on adding others.

technosophos
technosophos approved these changes Apr 4, 2022
View reviewed changes
Copy link
Collaborator

@technosophos technosophos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really, really cool! When the shortcodes PR gets merged, the combination of this one and that one will mean we can easily embed stuff like this in Markdown! 😄

@technosophos technosophos merged commit 208ee08 into fermyon:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technosophos technosophos technosophos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajatjindal @technosophos