-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest v2 support #132
Manifest v2 support #132
Conversation
0afb576
to
5cff623
Compare
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
This seems to be having a problem with the Spin |
Might have a logical conflict with @vdice's OCI changes; it's an old branch! |
The problem happens when a (v1, haven't tested with v2 yet) manifest omits the application HTTP |
Something amiss with the digest computation. When it has When it doesn't have The digest is coming from within the |
|
Correction. |
We should probably rethink how we track readiness. Cloud already assigns a unique ID to each deployment; we should be able to expose it in the |
Sure. That might need a Cloud API update - looking at the Swagger it seems like the only place the deployment ID is currently returned is in logs, though I could well be missing something! @bacongobbler is the deployment ID available during the deployment cycle itself? |
Yes, it should be. Cloud assigns a unique ID to each deployment and passes that ID to the runtime. |
The diagnosis of OCI digest weirdness was wrong. Baseless applications don't come ready at all - the supposed digest issue was down to the old application still being live. |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
I think this is good to go. Thank you @lann for the HTTP base fix! |
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess @itowlson has reviewed my contribution here so its fine for me to review his...
For when spinframework/spin#1780 lands. The new load path moves all of the LockedApp fiddliness into the Spin loader, so we pretty much don't have to do anything to consume it any more!
The Spin crate references will need to be set back to the Fermyon repo at this point - this points them at @lann's branch just for development.