Split up some large command handlers #96
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things (in two separate commits, as all of this is likely to be subjective). It is purely a refactoring and should not change any existing behaviour. (Okay, okay. In the vanishingly implausible cases where an app has an empty URL, the print behaviour changes slightly. Truth in advertising.)
apps
andsqlite
command handlers into subcommand handlers. This removes two levels of indentation from the actual command handling code, to my eye making it easier to track, and creates some visual separation between the subcommand blocks.spin cloud apps info
command by moving some logic into helper functions, and teasing apart the "what do we want to print" from the actual printing. I feel this makes it easier to read as a "top to bottom" function by reducing the nested ifs/matches.