Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crates to build on nightly #98

Closed
wants to merge 0 commits into from
Closed

Update crates to build on nightly #98

wants to merge 0 commits into from

Conversation

itowlson
Copy link
Contributor

Fixes #90.

lann
lann approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@lann lann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even consider "just update everything" 🤦

@itowlson itowlson closed this Sep 24, 2023
@itowlson
Copy link
Contributor Author

It looks like another PR (possibly #93) also updated Cargo.lock in a way that when I rebased this there were no outstanding changes. @lann main now builds on nightly for me - please yell out if it doesn't for you!

@itowlson itowlson mentioned this pull request Sep 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-goldenring kate-goldenring kate-goldenring approved these changes

@lann lann lann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build broken on nightly
3 participants
@itowlson @lann @kate-goldenring