Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single dash in new http-rust project name works, but two dashes do not #39

Closed
1 of 3 tasks
gmlewis opened this issue Nov 4, 2023 · 3 comments
Closed
1 of 3 tasks

Comments

@gmlewis
Copy link

gmlewis commented Nov 4, 2023

Describe the bug
Following the instructions in this video works, but if you name your project "hello-rust-2" instead of "hello-world", spin up fails.

Frequency of the bug
Please check one:

  • Consistent repro
  • Intermittent repro
  • No repro

Set-up information

$ spin -V
spin 2.0.0 (e4bb235 2023-11-03)

To Reproduce
Steps to reproduce the behavior:

  1. Follow the instructions in the above video but name your new project hello-rust-2 instead of hello-world.
  2. Run spin build then spin up.

Expected behavior
It should create a localhost:3000 server and serve your new Spin app.

Screenshots
spin-2-2023-11-04_11-15-55

Additional context
Here is the error from spin up:

$ spin up
Error: TOML parse error at line 11, column 13
   |
11 | component = "hello-rust-2"
   |             ^^^^^^^^^^^^^^
data did not match any variant of untagged enum ComponentSpec
@lann
Copy link

lann commented Nov 4, 2023

Thanks for the report! The actual constraint is in starting a "word" with a digit, but the error reporting is bad: spinframework/spin#1950

@tschneidereit
Copy link

I also just filed spinframework/spin#2051 to track validating component names earlier, so that the error message doesn't happen quite as late.

@vdice
Copy link
Member

vdice commented Nov 13, 2023

Now fixed (in canary) by spinframework/spin#2092. Thank you!

@vdice vdice closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants