Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate component name during spin new, spin add, and spin build #2051

Closed
3 tasks
tschneidereit opened this issue Nov 4, 2023 · 0 comments · Fixed by #2056
Closed
3 tasks

Validate component name during spin new, spin add, and spin build #2051

tschneidereit opened this issue Nov 4, 2023 · 0 comments · Fixed by #2056
Assignees
@itowlson
Labels
area/app-def-and-config Application definition and manifest area/CLI CLI enhancement New feature or request

Comments

@tschneidereit
Copy link
Contributor

Right now, component names are only validated when trying to run the component. We should instead also apply the validation during all operations where we touch a component. I think that means validating it in

  • spin new
  • spin add
  • spin build
@tschneidereit tschneidereit added enhancement New feature or request area/CLI CLI area/app-def-and-config Application definition and manifest labels Nov 4, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage Needed in Spin Triage Nov 4, 2023
@tschneidereit tschneidereit mentioned this issue Nov 4, 2023
Closed
3 tasks
@lann lann mentioned this issue Nov 4, 2023
Closed
@itowlson itowlson self-assigned this Nov 5, 2023
@itowlson itowlson linked a pull request Nov 5, 2023 that will close this issue
Error at new time if name is not usable #2056
Merged
@github-project-automation github-project-automation bot moved this from 🆕 Triage Needed to ✅ Done in Spin Triage Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itowlson itowlson

Labels
area/app-def-and-config Application definition and manifest area/CLI CLI enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error at new time if name is not usable itowlson/spin
2 participants
@tschneidereit @itowlson