test: cleanup testing examples #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adamreese
commented
Jun 26, 2024
adamreese
commented
- Remove redundant building of examples in the Makefile
- Split building and starting the Spin apps to fail faster if there's a build issue
Signed-off-by: Adam Reese <adam@reese.io>
Signed-off-by: Adam Reese <adam@reese.io>
endocrimes
approved these changes
Aug 26, 2024
endocrimes
reviewed
Aug 26, 2024
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| for _, example := range examples { |
There was a problem hiding this comment.
Might actually need to
example := example
Below to ensure this is captured in the parallel execution, but otherwise my LGTM still stands
Signed-off-by: Adam Reese <adam@reese.io>
adamreese
force-pushed
the
ref/test-examples
branch
from
ad77c84
to
a8a91f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.