Add constructor for HostComponentInitData #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
reviewed
Jun 15, 2023
crates/trigger/src/lib.rs
Outdated
Comment on lines
169
to
174
| key_value_init_values: &[(String, String)], | ||
| sqlite_init_statements: &[String], | ||
| ) -> Self { | ||
| Self { | ||
| kv: key_value_init_values.to_vec(), | ||
| sqlite: sqlite_init_statements.to_vec(), |
There was a problem hiding this comment.
A little more flexible (and equivalent for those specific argument types):
Suggested change
| key_value_init_values: &[(String, String)], | |
| sqlite_init_statements: &[String], | |
| ) -> Self { | |
| Self { | |
| kv: key_value_init_values.to_vec(), | |
| sqlite: sqlite_init_statements.to_vec(), | |
| key_value_init_values: impl Into<Vec<(String, String)>>, | |
| sqlite_init_statements: impl Into<Vec<String>>, | |
| ) -> Self { | |
| Self { | |
| kv: key_value_init_values.into(), | |
| sqlite: sqlite_init_statements.into(), |
There was a problem hiding this comment.
Oh, of course - thanks!
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson
force-pushed
the
public-host-component-init-data
branch
from
36ac19c
to
04b5fa8
Compare
lann
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a purely technical change to better support embedding scenarios. At the moment, an embedder wanting to leverage
TriggerExecutorBuilder::build()can only provide empty initialisation data; this provides for embedders to supportspin up --key-value-style storage setup features.